Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cname argument to deploy-book workflow #496

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

brian-rose
Copy link
Member

@brian-rose brian-rose commented Nov 7, 2024

This needs doing for consistency with ProjectPythia/cookbook-actions#135

Publishing of the preview is expected to fail here.

@brian-rose brian-rose requested a review from a team as a code owner November 7, 2024 22:00
@brian-rose brian-rose requested review from mgrover1 and erogluorhan and removed request for a team November 7, 2024 22:00
@brian-rose brian-rose changed the title Remove cname argument to publish-book action Remove cname argument to deploy-book workflow Nov 7, 2024
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@brian-rose brian-rose merged commit 0a92f87 into ProjectPythia:main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants