Skip to content

Commit

Permalink
Fix for previous attempt to avoid launching parallel test nodes when …
Browse files Browse the repository at this point in the history
…they aren't needed - even with a single test, if multiple languages are selected then parallel can be useful (#3377)
  • Loading branch information
bspratt authored Feb 24, 2025
1 parent 207c92d commit ff3d22e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pwiz_tools/Skyline/SkylineTester/TabTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ public override bool Run()
if (GetTestList().Length > 0)
args.Append(" perftests=on"); // In case any perf tests were explicitly selected - no harm if they weren't

if (MainWindow.RunParallel.Checked && GetTestCount() > 1) // No need for parallel on a single test
if (MainWindow.RunParallel.Checked &&
GetTestCount()*cultures.Count > 1) // No need to fire up parallel nodes on a single test in single culture
{
// CONSIDER: Should we add a checkbox for this?
// args.Append(" keepworkerlogs=1"); // For debugging startup issues. Look for TestRunner-docker-worker_#-docker.log files in pwiz root
Expand Down

0 comments on commit ff3d22e

Please sign in to comment.