ViewEditor non-modal operation and Apply button #3356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IResources into ToolsResources
…ry with alphapeptdeep" This reverts commit 5c487ab. Tempororily remove this commit to make TeamCity build succeeds
…om skyline document
…alphapeptdeep cli to build library
… library file to be skyline compatible
…to .blib and import into skyline
…k/20240403_PeakTotalIonCurrentArea
…k/20240403_PeakTotalIonCurrentArea
…k/20240403_PeakTotalIonCurrentArea
…yline/work/20240816_pythoninstaller_with_virtual_env_support and address issues brought up during buddy testing # Resolved Conflicts: # pwiz_tools/Skyline/SettingsUI/PeptideSettingsUI.cs
…support' of https://github.com/ProteoWizard/pwiz into 20250113_Carafe_CUDA_Apply
… "Apply" button. Enable Carafe for testing/development in this branch.
…er.cs so changes can be made via Visual Studio Designer going forward. Thanks for the testing Nick!
…rom running AlphaPeptDeep will be logged to the Immediate Window
…yline/work/20240816_pythoninstaller_with_virtual_env_support
…support' of https://github.com/ProteoWizard/pwiz into 20250113_Carafe_CUDA_Apply
…hen present ViewEditor becomes non-modal, when absent modal. Make ViewEditor "Manage Reports" modal and "Edit Report" non-modal.
…yline/work/20250113_Carafe_CUDA_Apply
…n-modal ViewEditor operation. Fixed a bug with Manage Reports preventing saving of columns in new reports or edits to existing.
…yline/work/20240816_pythoninstaller_with_virtual_env_support
|
You should revert the AlphaPeptDeep changes from this pull request. |
…s when "Cancel" is pressed. Update to Python installer to improve user experience.
…support' of https://github.com/ProteoWizard/pwiz into Skyline/work/20250203_ViewEditorApplyButton
…d ViewEditor, improving the functionality of the "Apply" button. Prevent blank or duplicated report names.
…ual_env_support' of https://github.com/ProteoWizard/pwiz into Skyline/work/20250203_ViewEditorApplyButton" This reverts commit c119e55, reversing changes made to 7b25be3.
…yline/work/20250203_ViewEditorApplyButton
…odal ViewEditor and Apply feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements non-modal operation and 'Apply' button that shows immediate changes to columns on the report without closing the dialog for ViewEditor when accessed by Document Grid -> Reports -> Edit Report:
Modal operation is preserved and 'Apply' button is not displayed when ViewEditor is accessed by Document Grid -> Reports -> Manage Reports