Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same TSPlayer.Active check #2939

Merged

Conversation

sgkoishi
Copy link
Member

Currently some use Player.active while some use TSPlayer.Active. They usually behave the same but this inconsistency causes problems when trying to do something related - e.g. hide a player.
This PR unify them to use the same TSPlayer.Active.

@AgaSpace
Copy link
Contributor

AgaSpace commented Jun 8, 2023

If some plugin will assign a value to TSPlayer.Active, such as the same Ghost, then we will get a player who can ignore most anti-cheats.

@sgkoishi
Copy link
Member Author

sgkoishi commented Jun 8, 2023

If some plugin will assign a value to TSPlayer.Active, such as the same Ghost, then we will get a player who can ignore most anti-cheats.

Players are always active without plugin. If a player is not TSPlayer.Active or Player.active, it makes sense to reject them - which is the current behaviour (and the PR is not breaking it).

@hakusaro hakusaro enabled auto-merge January 25, 2025 14:03
@hakusaro hakusaro merged commit 251353c into Pryaxis:general-devel Jan 25, 2025
7 of 8 checks passed
@sgkoishi sgkoishi deleted the consistency-playeractive-patch branch January 26, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants