Fixes and additions #672
Fixes and additions #672
Conversation
This allows the firmware driver to be discounted when not available (e.g. using KMS driver) (original commit by popcornmix popcornmix@b30fc83)
Signed-off-by: Jonas Karlman <jonas@kwiboo.se> (original commit by popcornmix popcornmix@6239ae1)
|
Addition: I tought I once made already a pull request of that so probably it flew out or is already incorporated... |
|
referencing to #637 |
|
just took a quick look at these patches. looking good in general, but can you squash the audio related commits into 1 (you've changed the signature of 2082445 contains some things that are local to your system that should be removed. from the looks of it, it's just the size of the buffer that needed fixing up. I'll give it another proper review after it's been cleaned up and will merge it one once it's ok, thanks. |
|
of course. |
may I ask to which part you are refering? |
|
the cmake defines and printf() change |
|
Same for me: The correct volume level is returned but when I change the volume still the previous volume level is returned. When I reconnect to the CEC adapter, the new correct volume level is returned. Can I test your fix in advance, before the next release? |
|
@MP-Munich Sure you can test it. So far it worked for me. The only thing that I did not know was whether the new volume level should be save and returned internally by libcec or whether there should be a re-read for the new volume level from the device. The internal processing bears the probabilty of non-device volumes, whereas the device version would provoke more traffic on the bus... Probably @opdenkamp will have suggestion. @mp and @opdenkamp I did not forget to work on that, but so far it lacked for the time doing it... |
|
Thanks for your reply. |
Some additions & fixes I made. I hope you could incorporate some. I jsut saw you did a lot of work there....