Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open browser functionality #517

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix open browser functionality #517

merged 1 commit into from
Dec 13, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Dec 13, 2024

  1. If there is no browser available, we can't open one.
  2. Since the health check is coming from the same machine and thus doesn't see any proxy, we cannot use config._url since that includes the root_path.

@pmeier pmeier merged commit ecce568 into main Dec 13, 2024
9 of 10 checks passed
@pmeier pmeier deleted the fix-open-browser branch December 13, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant