Skip to content

Commit

Permalink
Actually do Core is UniformShape
Browse files Browse the repository at this point in the history
  • Loading branch information
adityagoel4512 committed Aug 29, 2024
1 parent dfb1546 commit aea1f17
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions ndonnx/_core/_boolimpl.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
import ndonnx._opset_extensions as opx

from ._coreimpl import CoreOperationsImpl
from ._interface import OperationsBlock
from ._nullableimpl import NullableOperationsImpl
from ._shapeimpl import UniformShapeOperations
from ._utils import binary_op, unary_op, validate_core

if TYPE_CHECKING:
from ndonnx import Array


class _BooleanOperationsImpl(UniformShapeOperations):
class _BooleanOperationsImpl(OperationsBlock):
@validate_core
def equal(self, x, y) -> Array:
return binary_op(x, y, opx.equal)
Expand Down
4 changes: 2 additions & 2 deletions ndonnx/_core/_coreimpl.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
import ndonnx.additional as nda
from ndonnx._corearray import _CoreArray

from ._interface import OperationsBlock
from ._shapeimpl import UniformShapeOperations
from ._utils import validate_core

if TYPE_CHECKING:
from ndonnx._array import Array
from ndonnx._data_types import Dtype


class CoreOperationsImpl(OperationsBlock):
class CoreOperationsImpl(UniformShapeOperations):
def make_array(
self,
shape: tuple[int | None | str, ...],
Expand Down
4 changes: 2 additions & 2 deletions ndonnx/_core/_nullableimpl.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import ndonnx as ndx

from ._interface import OperationsBlock
from ._shapeimpl import UniformShapeOperations
from ._utils import validate_core

if TYPE_CHECKING:
Expand All @@ -16,7 +16,7 @@
Dtype = Union[CoreType, StructType]


class NullableOperationsImpl(OperationsBlock):
class NullableOperationsImpl(UniformShapeOperations):
@validate_core
def fill_null(self, x: Array, value) -> Array:
value = ndx.asarray(value)
Expand Down
4 changes: 2 additions & 2 deletions ndonnx/_core/_numericimpl.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
from ndonnx._utility import promote

from ._coreimpl import CoreOperationsImpl
from ._interface import OperationsBlock
from ._nullableimpl import NullableOperationsImpl
from ._shapeimpl import UniformShapeOperations
from ._utils import (
binary_op,
from_corearray,
Expand All @@ -37,7 +37,7 @@
from ndonnx._corearray import _CoreArray


class _NumericOperationsImpl(UniformShapeOperations):
class _NumericOperationsImpl(OperationsBlock):
# elementwise.py

@validate_core
Expand Down
4 changes: 2 additions & 2 deletions ndonnx/_core/_stringimpl.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
import ndonnx._opset_extensions as opx

from ._coreimpl import CoreOperationsImpl
from ._interface import OperationsBlock
from ._nullableimpl import NullableOperationsImpl
from ._shapeimpl import UniformShapeOperations
from ._utils import binary_op, validate_core

if TYPE_CHECKING:
from ndonnx import Array


class _StringOperationsImpl(UniformShapeOperations):
class _StringOperationsImpl(OperationsBlock):
@validate_core
def add(self, x, y) -> Array:
return binary_op(x, y, opx.string_concat)
Expand Down

0 comments on commit aea1f17

Please sign in to comment.