Move Array API tests up and rename and address comments

.gitmodules

@@ -1,4 +1,3 @@
-[submodule "array-api-tests"]
-	path = api-coverage-tests
-	url = git@github.com:adityagoel4512/array-api-tests.git
-	branch = skip-unused-kinds-in-default
+[submodule "api-coverage-tests"]
+	path = array-api-tests
+	url = git@github.com:data-apis/array-api-tests.git

.pre-commit-config.yaml

@@ -48,7 +48,7 @@ repos:
         language: system
         types: [python]
         require_serial: true
-        exclude: ^(tests|api-coverage-tests)/
+        exclude: ^(tests|array-api-tests)/
       # prettier
       - id: prettier
         name: prettier

README.md

@@ -43,7 +43,7 @@ pytest tests -n auto
 
 It has a couple of key features:
 
-- It implements the [`Array API`](https://data-apis.org/array-api/) standard. Standard compliant code can be executed without changes across numerous backends such as like `NumPy`, `JAX` and now `ndonnx`.
+- It implements the [`Array API`](https://data-apis.org/array-api/) standard. Standard compliant code can be executed without changes across numerous backends such as like NumPy, JAX and now ndonnx.
 
   ```python
   import numpy as np
@@ -93,7 +93,7 @@ In the future we will be enabling a stable API for an extensible data type syste
 
 ## Array API coverage
 
-Array API compatibility is tracked in `api-coverage-tests`. Missing coverage is tracked in the `skips.txt` file. Contributions are welcome!
+Array API compatibility is tracked in `array-api-tests`. Missing coverage is tracked in the `skips.txt` file. Contributions are welcome!
 
 Summary(1119 total):
 

ndonnx/_array.py

@@ -261,7 +261,7 @@ def device(self):
     def to_device(
         self, device: _Device, /, *, stream: int | Any | None = None
     ) -> Array:
-        if device is not device:
+        if device != self.device:
             raise ValueError("Cannot move Array to a different device")
         if stream is not None:
             raise ValueError("The 'stream' parameter is not supported in ndonnx.")

ndonnx/_info.py

@@ -4,7 +4,7 @@
 from __future__ import annotations
 
 import ndonnx as ndx
-from ndonnx._array import device
+from ndonnx._array import _Device, device
 from ndonnx._data_types import canonical_name
 
 
@@ -25,16 +25,16 @@ class ArrayNamespaceInfo:
         ndx.uint64,
     ]
 
-    def capabilities(self) -> dict:
+    def capabilities(self) -> dict[str, bool]:
         return {
             "boolean indexing": True,
             "data-dependent shapes": True,
         }
 
-    def default_device(self):
+    def default_device(self) -> _Device:
         return device
 
-    def devices(self) -> list:
+    def devices(self) -> list[_Device]:
         return [device]
 
     def dtypes(

pixi.toml

@@ -49,7 +49,7 @@ test = "pytest"
 test-coverage = "pytest --cov=ndonnx --cov-report=xml --cov-report=term-missing"
 
 [feature.test.tasks.arrayapitests]
-cmd = "pytest api-coverage-tests/array_api_tests/ -v -rfX --json-report --json-report-file=api-coverage-tests.json -n auto --disable-deadline --disable-extension linalg --skips-file=skips.txt --xfails-file=xfails.txt"
+cmd = "pytest array_api_tests/ -v -rfX --json-report --json-report-file=api-coverage-tests.json -n auto --disable-deadline --disable-extension linalg --skips-file=skips.txt --xfails-file=xfails.txt"
 [feature.test.tasks.arrayapitests.env]
 ARRAY_API_TESTS_MODULE = "ndonnx"
 ARRAY_API_TESTS_VERSION = "2023.12"

pyproject.toml

@@ -77,14 +77,14 @@ indent-style = "space"
 python_version = '3.10'
 no_implicit_optional = true
 check_untyped_defs = true
-exclude = ["api-coverage-tests", "tests"]
+exclude = ["array-api-tests", "tests"]
 
 [[tool.mypy.overrides]]
 module = ["onnxruntime"]
 ignore_missing_imports = true
 
 [tool.pytest.ini_options]
-addopts = "--ignore=api-coverage-tests"
+addopts = "--ignore=array-api-tests"
 filterwarnings = ["ignore:.*google.protobuf.pyext.*:DeprecationWarning"]
 
 [tool.typos.default]