Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden static_map support #67

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Broaden static_map support #67

merged 1 commit into from
Aug 28, 2024

Conversation

adityagoel4512
Copy link
Member

@adityagoel4512 adityagoel4512 commented Aug 28, 2024

static_map was (probably) originally conceived as a thin LabelEncoder wrapper. This cleans up some issues with non int64 integers and strings. Closes #63.

ndonnx/additional/_additional.py Outdated Show resolved Hide resolved
@adityagoel4512 adityagoel4512 force-pushed the static-map branch 2 times, most recently from 2189aea to 5316ecc Compare August 28, 2024 11:22
@adityagoel4512 adityagoel4512 merged commit dad0f2c into main Aug 28, 2024
16 checks passed
@adityagoel4512 adityagoel4512 deleted the static-map branch August 28, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static_map doesn't work for integer types other than int64
2 participants