Test clean up and add python 3.13 test feature #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagoel4512
force-pushed
the
test-cleanup-py313
branch
from
300c865 to
2b53bc7
Compare
adityagoel4512
force-pushed
the
test-cleanup-py313
branch
from
2b53bc7 to
9640b42
Compare
adityagoel4512
changed the title
neNasko1
reviewed
Jan 17, 2025
| @@ -554,60 +554,6 @@ def test_all(x): | |||
| assert_array_equal(ndx.all(x).to_numpy(), np.all(x.to_numpy())) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
Why are those tests redundant?
There was a problem hiding this comment.
See https://github.com/Quantco/ndonnx/blob/main/tests/test_additional.py#L15-L66 (note that the link is test_*additional*.py).
neNasko1
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we are:
Dropping numpy 1.x tests andadding a py313 featureEdit: I am going to retain the NumPy 1.x feature for the time being. We can drop it in line with https://scientific-python.org/specs/spec-0000/. We will also drop python 3.10 soon.