-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support manifest path to project directory #94
Conversation
Allow `pixi-pack pack <manifest-path>` to accept a path to a project directory. This ports the same feature added to upstream Pixi here prefix-dev/pixi#2716. This also adds an additional check if the manifest path is invalid and display an error. Fixes: Quantco#93 Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
354b64e
to
30c9791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could you add a test please?
I added an integration test, and that test is passing. However now a different macos started failing. It's not clear to me why, as it passed the previous run and it doesn't appear to be related to my changes 😕 |
Can you please try to add the following @blmaier? I can't push to your branch.
|
this is not necessary as 0.41.2 just got pulled because of prefix-dev/pixi#3112 rerunning ci works ✅ |
for future reference: the following error with pixi 0.41.2 on macos
|
Allow
pixi-pack pack <manifest-path>
to accept a path to a project directory. This ports the same feature added to upstream Pixi here prefix-dev/pixi#2716.This also adds an additional check if the manifest path is invalid and display an error.
Fixes: #93
Motivation
This makes pixi-pack align with how
pixi --manifest-path
works.This fixes the bug in #93 where if a directory is used for
pixi-pack pack <directory>
, pixi pack doesn't handle it correctly and searches the directory's parent for the pixi.lock