-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend elastic properties to MLPs, and include elastic property analysis #2693
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zulissimeta! This largely looks sensible to me. I have a few suggestions and requests in my review comments, mostly about user-facing choices and documentation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 97.48% 97.40% -0.09%
==========================================
Files 90 91 +1
Lines 3860 3892 +32
==========================================
+ Hits 3763 3791 +28
- Misses 97 101 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of Changes
This PR extends elasticity support and addresses a few quality-of-life issues for running elastic workflows:
Requirements
main
).Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.