-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimizer is now better at recognizing constProp #7316
fix: optimizer is now better at recognizing constProp #7316
Conversation
🦋 Changeset detectedLatest commit: 82d24fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, but it looks like _create_synthetic_qsegment
is returning is_const=false because it's a simple identifier, and it doesn't know if the identifier is const.
So we need to pass the const identifiers to that function.
It's important to get this right because putting a handler in a variable before passing it as a handler is very common.
packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__ternary_prop.snap
Show resolved
Hide resolved
…m/JerryWu1234/qwik into 7216_fox_props_over_-overwrite_v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it?
fixes: #7216
Optimize the Optimize, has been better at recognizing constProp
Description
Checklist
pnpm change