Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): use sets instead of arrays for effects #7327

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Feb 9, 2025

No description provided.

Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: afa1089

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Varixo and others added 3 commits February 10, 2025 22:00
@Varixo Varixo force-pushed the v2-use-set-for-effects branch from c7342cb to afa1089 Compare February 11, 2025 16:08
@Varixo Varixo marked this pull request as ready for review February 11, 2025 16:20
@Varixo Varixo requested a review from a team as a code owner February 11, 2025 16:20
Copy link

pkg-pr-new bot commented Feb 11, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7327
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7327
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7327
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7327

commit: afa1089

Copy link
Contributor

github-actions bot commented Feb 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview afa1089

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit a6ea466 into build/v2 Feb 11, 2025
19 checks passed
@wmertens wmertens deleted the v2-use-set-for-effects branch February 11, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants