Fix/45 pass currencies explicitly (#46)

Pass `currencies` object explicitly to `check_missing_currency()` closes #45 --------- Co-authored-by: CJ Yetman <cj@cjyetman.com>
RMI-PACTA · May 16, 2024 · ac9144f · ac9144f
1 parent d221800
commit ac9144f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/R/add_portfolio_flags.R b/R/add_portfolio_flags.R
@@ -5,16 +5,21 @@
 #' financial data.
 #'
 #' @param portfolio A data frame containing a portfolio
+#' @param currencies A data frame containing ISO 4217 currency codes and their exchange
+#' rates.
 #'
 #' @return A data frame of the portfolio with the flags columns added
 #'
 #' @export
 
-add_portfolio_flags <- function(portfolio) {
+add_portfolio_flags <- function(
+  portfolio,
+  currencies
+) {
   ### FLAGS/Exclusions
 
   portfolio <- check_isin_format(portfolio)
-  portfolio <- check_missing_currency(portfolio)
+  portfolio <- check_missing_currency(portfolio, currencies)
   portfolio <- check_valid_input_value(portfolio)
   portfolio <- check_financial_data(portfolio)
 

diff --git a/R/check_missing_currency.R b/R/check_missing_currency.R
@@ -1,4 +1,7 @@
-check_missing_currency <- function(portfolio_total) {
+check_missing_currency <- function(
+  portfolio_total,
+  currencies
+  ) {
   # Currency blank or not in our currency data frame
   portfolio_total %>%
     mutate(has_currency = case_when(

diff --git a/man/add_portfolio_flags.Rd b/man/add_portfolio_flags.Rd