Skip to content

Commit

Permalink
Merge branch 'amd-staging' into dgaliffi/6.3/rebrand
Browse files Browse the repository at this point in the history
  • Loading branch information
dgaliffiAMD committed Nov 6, 2024
2 parents e497928 + 7821707 commit 6c57dfc
Show file tree
Hide file tree
Showing 359 changed files with 2,184 additions and 1,409 deletions.
2 changes: 1 addition & 1 deletion .azuredevops/rocm-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ pr:
drafts: false

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/omniperf.yml@pipelines_repo
- template: ${{ variables.CI_COMPONENT_PATH }}/rocprofiler-compute.yml@pipelines_repo
8 changes: 7 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
* @koomie @coleramos425
* @coleramos425 @feizheng10 @dgaliffiAMD

# Documentation files
docs/ @ROCm/rocm-documentation
*.md @ROCm/rocm-documentation
*.rst @ROCm/rocm-documentation
.readthedocs.yaml @ROCm/rocm-documentation

# Packaging
cmake/ @koomie
tests/ @koomie
CMakeLists.txt @koomie
utils/ @koomie
33 changes: 0 additions & 33 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

131 changes: 131 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
name: Bug Report
description: Report a bug you've encountered for further investigation
title: "[Bug]: "
labels: ["bug", "triage"]
assignees:
- njobypet
body:
- type: markdown
attributes:
value: |
Please complete the following form.
- type: textarea
id: bug-description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is.
placeholder: e.g. I found the following error when trying to...
validations:
required: true

- type: markdown
attributes:
value: |
## Development Environment
- type: input
id: linux-distro
attributes:
label: Linux Distribution
description: |
What operating system are you using? Hint:
```shell
echo "OS:" && cat /etc/os-release | grep -E "^(NAME=|VERSION=)"
```
placeholder: e.g. Ubuntu 22.04
validations:
required: true

- type: input
id: rocprofiler-compute-version
attributes:
label: ROCm Compute Profiler Version
description: |
What version of ROCm Compute Profiler are you using? Hint:
```shell
rocprof-compute --version
```
placeholder: e.g. 2.1.0
validations:
required: true

- type: input
id: gpu
attributes:
label: GPU
description: |
What GPU(s) did you encounter the issue on? Hint:
```shell
echo "GPU:" && /opt/rocm/bin/rocminfo | grep -E "^\s*(Name|Marketing Name)"
```
placeholder: e.g. AMD MI250, AMD MI300X
validations:
required: true

- type: input
id: rocm-version
attributes:
label: ROCm Version
description: |
What version(s) of ROCm did you encounter the issue on? Deduce from:
```shell
readlink -f $(which rocprof)
```
placeholder: e.g. ROCm 6.0.2

- type: input
id: cluster
attributes:
label: Cluster name (if applicable)
description: What is the name of the cluster you are using?
placeholder: e.g. Frontier, El Capitan, etc.

- type: markdown
attributes:
value: |
## To Reproduce
- type: textarea
id: reproducer
attributes:
label: Reproducer
description: Steps to reproduce the behavior
placeholder: |
1. Run '...'
2. Go to '...'
3. Click on '....'
4. See error
validations:
required: true

- type: textarea
id: expected-behav
attributes:
label: Expected behavior
description: A clear and concise description of what you expected to happen.
placeholder: e.g. I expected the following to happen...

- type: markdown
attributes:
value: |
## Other
- type: textarea
id: logs
attributes:
label: Relevant log output
description: Please copy and paste rocprofiler-compute's `log.txt` file. This will be automatically formatted into code, so no need for backticks.
render: shell

- type: textarea
id: screenshots
attributes:
label: Screenshots
description: If applicable, add screenshots to help explain your problem.

- type: textarea
id: context
attributes:
label: Additional Context
description: Add any other context about the problem here.
20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

45 changes: 45 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Feature Request
description: Suggest an idea for this project
title: "[Req]: "
labels: ["enhancement", "triage"]
assignees:
- njobypet
body:
- type: markdown
attributes:
value: |
Please complete the following form.
- type: textarea
id: problem
attributes:
label: Is your feature request related to a problem?
description: A clear and concise description of what the problem is.
placeholder: e.g. I'm always frustrated when...
validations:
required: true

- type: textarea
id: solution
attributes:
label: Describe the solution you'd like
description: A clear and concise description of what you want to happen.
placeholder: e.g. I propose that...
validations:
required: true

- type: textarea
id: alternatives
attributes:
label: Describe any alternatives you've considered
description: Walk through your thought process and how you arrived at your solution.
placeholder: |
e.g. Some alternative approaches might be:
1. ...
2. ...
- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context or screenshots about the feature request here.
14 changes: 0 additions & 14 deletions .github/ISSUE_TEMPLATE/question.md

This file was deleted.

23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/question.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Question
description: Clarifying questions and uncertainties
labels: ["question"]
body:
- type: markdown
attributes:
value: |
Please complete the following form.
- type: textarea
id: question
attributes:
label: Describe your question
description: A clear and concise description of your question and how it came up.
placeholder: I was unsure how to ...
validations:
required: true

- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context or screenshots about the question here.
6 changes: 3 additions & 3 deletions .github/workflows/mi-rhel9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,17 @@ jobs:
run: |
cd build
make
srun -N 1 -J omniperf -p $CI_QUEUE -t 00:20:00 ctest -j 4 --resource-spec-file ../tests/4gpus.json --verbose -L profile
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:20:00 ctest -j 4 --resource-spec-file ../tests/4gpus.json --verbose -L profile
- name: Run [analyze workloads] mode
if: '!cancelled()'
run: |
cd build
srun -N 1 -J omniperf -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_workloads
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_workloads
- name: Run [analyze commands] mode
if: '!cancelled()'
run: |
cd build
srun -N 1 -J omniperf -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_commands
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_commands
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action/linux@v2
if: always()
Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,29 @@ jobs:
cd build
make package_source
- name: Rename tarball
run: mv build/omniperf-*.tar.gz build/omniperf-${{github.ref_name}}.tar.gz
run: mv build/rocprofiler-compute-*.tar.gz build/rocprofiler-compute-${{github.ref_name}}.tar.gz
- name: Archive tarball
uses: actions/upload-artifact@v4
with:
name: omniperf-${{github.ref_name}}.tar.gz
path: build/omniperf-${{github.ref_name}}.tar.gz
name: rocprofiler-compute-${{github.ref_name}}.tar.gz
path: build/rocprofiler-compute-${{github.ref_name}}.tar.gz
- name: Set version
run: echo "VERSION=$(cat VERSION)" >> $GITHUB_ENV
- name: Determine release name
run: |
if [[ ${{github.ref_name}} == rocm-* ]]; then
echo "RELEASE_NAME=Omniperf ${{ env.VERSION }} for ${{github.ref_name}}"
echo "RELEASE_NAME=rocprofiler-compute ${{ env.VERSION }} for ${{github.ref_name}}"
else
echo "RELEASE_NAME=Omniperf ${{ env.VERSION }}"
echo "RELEASE_NAME=rocprofiler-compute ${{ env.VERSION }}"
fi >> $GITHUB_ENV
- name: Upload tarball Release Asset
uses: softprops/action-gh-release@v2
if: startsWith(github.ref, 'refs/tags/') && github.repository == 'ROCm/omniperf'
if: startsWith(github.ref, 'refs/tags/') && github.repository == 'ROCm/rocprofiler-compute'
with:
fail_on_unmatched: True
generate_release_notes: True
draft: False # toggle for debugging
files: |
build/omniperf-${{github.ref_name}}.tar.gz
build/rocprofiler-compute-${{github.ref_name}}.tar.gz
name: ${{ env.RELEASE_NAME }}

2 changes: 1 addition & 1 deletion .github/workflows/rhel-8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: |
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=/opt/omniperf -DPYTEST_NUMPROCS=4 ..
cmake -DCMAKE_INSTALL_PREFIX=/opt/rocprofiler-compute -DPYTEST_NUMPROCS=4 ..
make install
- name: CTest- Analyze Commands
run: |
Expand Down
Loading

0 comments on commit 6c57dfc

Please sign in to comment.