Skip to content

Commit

Permalink
Fix executable name.
Browse files Browse the repository at this point in the history
Signed-off-by: xuchen-amd <xuchen@amd.com>
  • Loading branch information
xuchen-amd committed Oct 23, 2024
1 parent d4e00ed commit 8e4e774
Show file tree
Hide file tree
Showing 15 changed files with 281 additions and 286 deletions.
2 changes: 1 addition & 1 deletion .azuredevops/rocm-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ pr:
drafts: false

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocprofiler-compute.yml@pipelines_repo
- template: ${{ variables.CI_COMPONENT_PATH }}/omniperf.yml@pipelines_repo
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ A clear and concise description of what the bug is.

**Development Environment:**
- Linux Distribution: [e.g. Ubuntu20.04, RHEL8]
- ROCm Compute Profiler Version: [e.g. try `rocprofiler-compute --version`]
- ROCm Compute Profiler Version: [e.g. try `rocprof-compute --version`]
- GPU: [e.g. Mi100, Mi200]
- Custer (if applicable): [e.g. Crusher, ]

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ body:
description: |
What version of ROCm Compute Profiler are you using? Hint:
```shell
rocprofiler-compute --version
rocprof-compute --version
```
placeholder: e.g. 2.1.0
validations:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/mi-rhel9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,17 @@ jobs:
run: |
cd build
make
srun -N 1 -J rocprofiler-compute -p $CI_QUEUE -t 00:20:00 ctest -j 4 --resource-spec-file ../tests/4gpus.json --verbose -L profile
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:20:00 ctest -j 4 --resource-spec-file ../tests/4gpus.json --verbose -L profile
- name: Run [analyze workloads] mode
if: '!cancelled()'
run: |
cd build
srun -N 1 -J rocprofiler-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_workloads
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_workloads
- name: Run [analyze commands] mode
if: '!cancelled()'
run: |
cd build
srun -N 1 -J rocprofiler-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_commands
srun -N 1 -J rocprof-compute -p $CI_QUEUE -t 00:10:00 ctest --verbose -R test_analyze_commands
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action/linux@v2
if: always()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,5 @@ jobs:
module use $INSTALL_DIR/rocprofiler-compute/share/rocprofiler-compute/modulefiles
module load rocprofiler-compute
module list
rocprofiler-compute --version
rocprof-compute --version
2 changes: 1 addition & 1 deletion src/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This directory contains all the source code files for the ROCm Compute Profiler project.
The top-level `rocprofiler-compute` executable is the entry point and defines the flow for subsequent execution modes.
The top-level `rocprof-compute` executable is the entry point and defines the flow for subsequent execution modes.

To build ROCm Compute Profiler as a developer (from source) please add this directory to `PATH`.
You will find utilities and logic specific to ROCm Compute Profiler's different execution modes in their
Expand Down
4 changes: 2 additions & 2 deletions src/rocprof_compute_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def parse_args(self):
formatter_class=lambda prog: argparse.RawTextHelpFormatter(
prog, max_help_position=30
),
usage="rocprofiler-compute [mode] [options]",
usage="rocprof-compute [mode] [options]",
)
omniarg_parser(
parser, config.rocprof_compute_home, self.__supported_archs, self.__version
Expand All @@ -187,7 +187,7 @@ def parse_args(self):
sys.exit(0)
parser.print_help(sys.stderr)
console_error(
"rocprofiler-compute requires you pass a valid mode. Detected None."
"rocprof-compute requires you pass a valid mode. Detected None."
)
return

Expand Down
2 changes: 1 addition & 1 deletion src/rocprof_compute_profile/profiler_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def pre_processing(self):
self.__args.remaining = " ".join(self.__args.remaining)
else:
console_error(
"Profiling command required. Pass application executable after -- at the end of options.\n\t\ti.e. rocprofiler-compute profile -n vcopy -- ./vcopy -n 1048576 -b 256"
"Profiling command required. Pass application executable after -- at the end of options.\n\t\ti.e. rocprof-compute profile -n vcopy -- ./vcopy -n 1048576 -b 256"
)

# verify name meets MongoDB length requirements and no illegal chars
Expand Down
2 changes: 1 addition & 1 deletion src/roofline.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def profile(self):
if not self.__args.remaining:
console_error(
"profiling"
"An <app_cmd> is required to run.\nrocprofiler-compute profile -n test -- <app_cmd>"
"An <app_cmd> is required to run.\rrocprof-compute profile -n test -- <app_cmd>"
)
# TODO: Add an equivelent of characterize_app() to run profiling directly out of this module

Expand Down
2 changes: 1 addition & 1 deletion tests/generate_test_analyze_workloads.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
+ arch
+ "():"
+ "\n\twith pytest.raises(SystemExit) as e:"
+ "\n\t\twith patch('sys.argv',['rocprofiler-compute', 'analyze', '--path', '"
+ "\n\t\twith patch('sys.argv',['rocprof-compute', 'analyze', '--path', '"
+ workload
+ "/"
+ arch
Expand Down
4 changes: 2 additions & 2 deletions tests/generate_workloads.sh
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ echo "starting"
for key in "${!commands[@]}"; do
echo profiling $key;
command="${commands[$key]}"
echo "$key = ./src/rocprofiler-compute profile -n $key ${dirs[@]}"
./src/rocprofiler-compute profile -n $key $command -p tests/workloads/$key/$soc -- ./tests/vcopy -n 1048576 -b 256 -i 3 ;
echo "$key = ./src/rocprof-compute profile -n $key ${dirs[@]}"
./src/rocprof-compute profile -n $key $command -p tests/workloads/$key/$soc -- ./tests/vcopy -n 1048576 -b 256 -i 3 ;
echo "done" ; done
Loading

0 comments on commit 8e4e774

Please sign in to comment.