Force the LBAPI responses to be treated as UTF-8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the string handling within the toolkit leaves string encoding up to the platform which is often wrong. The updated code forces the response handling to treat the incoming response body as a UTF-8 encoded stream before handing off to GSON to deserialize. Updated the integration test to include a name that contains unicode characters and compares the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the string handling within the toolkit leaves string encoding
up to the platform which is often wrong.
The updated code forces the response handling to treat the incoming
response body as a UTF-8 encoded stream before handing off to GSON to
deserialize.
Updated the integration test to include a name that contains unicode
characters and compares the result.