Merge branch 'develop' into mentionDisplay

Real-Dev-Squad · Oct 26, 2024 · 7f5885a · 7f5885a
2 parents 51ff5f6 + 28636d7
commit 7f5885a
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/controllers/mentionEachUser.ts b/src/controllers/mentionEachUser.ts
@@ -27,6 +27,7 @@ export async function mentionEachUser(
   const msgToBeSent = transformedArgument?.displayMessageObj?.value;
   const dev = transformedArgument?.dev?.value || false;
   const showroles = transformedArgument?.showroles?.value || false;
+  // optional chaining here only because display message obj is optional argument
   const usersWithMatchingRole = filterUserByRoles(
     getMembersInServerResponse as UserArray[],
     roleId
@@ -50,6 +51,7 @@ export async function mentionEachUser(
     }
     return discordTextResponse(responseMessage);
   } else if (!dev || usersWithMatchingRole.length === 0) {
+  if (!dev || usersWithMatchingRole.length === 0) {
     const responseData = checkDisplayType({
       usersWithMatchingRole,
       msgToBeSent,