changed the feature flag name and removed nesting

Real-Dev-Squad · Oct 27, 2024 · faba991 · faba991
1 parent 7148548
commit faba991
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/constants/commands.ts b/src/constants/commands.ts
@@ -51,7 +51,7 @@ export const MENTION_EACH = {
       require: false,
     },
     {
-      name: "showroles",
+      name: "devtitle",
       description: "want to see extra details?",
       type: 5,
       require: false,

diff --git a/src/controllers/baseHandler.ts b/src/controllers/baseHandler.ts
@@ -75,8 +75,8 @@ export async function baseHandler(
         displayMessageObj: data.find((item) => item.name === "message"),
         channelId: message.channel_id,
         dev: data.find((item) => item.name === "dev") as unknown as DevFlag,
-        showroles: data.find(
-          (item) => item.name === "showroles"
+        devtitle: data.find(
+          (item) => item.name === "devtitle"
         ) as unknown as DevFlag,
       };
       return await mentionEachUser(transformedArgument, env, ctx);

diff --git a/src/controllers/mentionEachUser.ts b/src/controllers/mentionEachUser.ts
@@ -16,7 +16,7 @@ export async function mentionEachUser(
     roleToBeTaggedObj: MentionEachUserOptions;
     displayMessageObj?: MentionEachUserOptions;
     channelId: number;
-    showroles?: DevFlag;
+    devtitle?: DevFlag;
     dev?: DevFlag;
   },
   env: env,
@@ -26,7 +26,7 @@ export async function mentionEachUser(
   const roleId = transformedArgument.roleToBeTaggedObj.value;
   const msgToBeSent = transformedArgument?.displayMessageObj?.value;
   const dev = transformedArgument?.dev?.value || false;
-  const showroles = transformedArgument?.showroles?.value || false;
+  const devtitle = transformedArgument?.devtitle?.value || false;
   // optional chaining here only because display message obj is optional argument
   const usersWithMatchingRole = filterUserByRoles(
     getMembersInServerResponse as UserArray[],
@@ -38,7 +38,8 @@ export async function mentionEachUser(
     message: msgToBeSent,
     usersWithMatchingRole,
   };
-  if (transformedArgument.showroles?.value === true) {
+
+  if (transformedArgument.devtitle?.value === true) {
     let responseMessage = "";
     if (usersWithMatchingRole.length === 0) {
       responseMessage = `Sorry, no user found with <@&${roleId}> role.`;
@@ -50,7 +51,9 @@ export async function mentionEachUser(
       responseMessage = `The users with <@&${roleId}> role are ${payload.usersWithMatchingRole}.`;
     }
     return discordTextResponse(responseMessage);
-  } else if (!dev || usersWithMatchingRole.length === 0) {
+  }
+
+  if (!dev || usersWithMatchingRole.length === 0) {
     const responseData = checkDisplayType({
       usersWithMatchingRole,
       msgToBeSent,