Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response of /task command #184

Merged
merged 2 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/utils/formatTask.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ export function generateTaskResponseMessage(
formattedTasks: string[],
status: string
) {
const title = `## ${formatStatusToTitleCase(status)} Tasks of ${nickName}`;
const title =
formattedTasks.length !== 0
? `## ${formatStatusToTitleCase(status)} Tasks of ${nickName}`
: `## ${nickName} doesn't have any in-progress task`;
const tasks = formattedTasks.join("\n\n");
const allTaskLink = `[→ All Tasks](${RDS_STATUS_SITE_URL}/tasks?q=status:all+assignee:${nickName})
`;
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/utils/formatTask.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,18 @@ describe("Test generateTaskResponseMessage function", () => {
const expectedResponseMessage = `${expectedMessage}\n${task1}\n\n${task2}\n${allTaskURL}\n`;
expect(responseMessage).toBe(expectedResponseMessage);
});

it("should return a string if user don't have any in-progress task", () => {
const formattedTasks: [] = [];
console.log("format task frm fail", formattedTasks.length);
const responseMessage = generateTaskResponseMessage(
"anish-pawaskar",
formattedTasks,
"IN_PROGRESS"
);
const expectedMessage = `## anish-pawaskar doesn't have any in-progress task`;
const allTaskURL = `[→ All Tasks](https://status.realdevsquad.com/tasks?q=status:all+assignee:anish-pawaskar)`;
const expectedResponseMessage = `${expectedMessage}\n\n${allTaskURL}\n`;
expect(responseMessage).toBe(expectedResponseMessage);
});
});
Loading