Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add taskTitle field to /task/update API #227

Merged
merged 5 commits into from
May 5, 2024
Merged

add taskTitle field to /task/update API #227

merged 5 commits into from
May 5, 2024

Conversation

tejaskh3
Copy link
Member

@tejaskh3 tejaskh3 commented May 1, 2024

Date: 1 May, 2024

Developer Name: Tejas


Issue Ticket Number

#225

Description

This PR update adds taskTitle field to the existing API which sends task updates on RDS discord's tacking-updates channel, now we want to modify the message that should have an hyperlink to the task.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

image

Test Coverage

image

image

image

Additional Notes

@tejaskh3 tejaskh3 linked an issue May 1, 2024 that may be closed by this pull request
10 tasks
@tejaskh3 tejaskh3 self-assigned this May 1, 2024
lakshayman
lakshayman previously approved these changes May 1, 2024
Atifsid
Atifsid previously approved these changes May 1, 2024
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why coverage is low

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you tag the person in update text

@iamitprakash iamitprakash requested review from lakshayman and Atifsid May 1, 2024 17:42
@tejaskh3 tejaskh3 dismissed stale reviews from Atifsid and lakshayman via 0a0d4c3 May 1, 2024 18:22
@tejaskh3
Copy link
Member Author

tejaskh3 commented May 1, 2024

can you tag the person in update text

As we already discussed, we don't want to tag users.

@tejaskh3
Copy link
Member Author

tejaskh3 commented May 1, 2024

why coverage is low

updated, please check now.

@tejaskh3 tejaskh3 requested review from iamitprakash and yesyash May 1, 2024 19:56
src/utils/sendTaskUpdates.ts Show resolved Hide resolved
tests/unit/handlers/taskUpdateHandler.test.ts Outdated Show resolved Hide resolved
tests/unit/utils/sendTasksUpdates.test.ts Show resolved Hide resolved
@tejaskh3 tejaskh3 requested a review from yesyash May 5, 2024 06:49
@iamitprakash iamitprakash merged commit adcc1d2 into develop May 5, 2024
2 checks passed
@iamitprakash iamitprakash deleted the new-branch branch May 5, 2024 20:05
@tejaskh3 tejaskh3 mentioned this pull request May 5, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a hyperlink(task url) in the message
6 participants