Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS env variable in the readme file #295

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

vikhyat187
Copy link
Contributor

@vikhyat187 vikhyat187 commented Dec 22, 2024

Date: 22-12-24

Developer Name: Vikhyat


Issue Ticket Number

Description

Added the AWS env variable in the readme file of the discord slash command

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

@iamitprakash iamitprakash merged commit 6d99d4f into develop Dec 23, 2024
2 checks passed
@iamitprakash iamitprakash deleted the vikhyat187-patch-1 branch December 23, 2024 15:48
@pankajjs pankajjs mentioned this pull request Jan 19, 2025
10 tasks
mdansarijaved pushed a commit to mdansarijaved/discord-slash-commands that referenced this pull request Jan 23, 2025
iamitprakash added a commit that referenced this pull request Jan 25, 2025
* Added AWS env variable in the readme file (#295)

* feat: Added tests to support onboarding-extension-command

- Added command and handler

- Changed required default value

- Added constant message

- Changed field name and argument

- Fixed function argument and types

- Added super user field

- Added validation for super-user and fixed reply

- Changed field, expectation message and test name as it was failing

- Restore all mocks in after-each hook

- Fixed lint issue

- Added assert statement to verify the function call signature and fixed test name

- Added tests to handle edge cases and fixed existing failing tests

---------

Co-authored-by: Vikhyat Bhatnagar <52795644+vikhyat187@users.noreply.github.com>
Co-authored-by: Pankaj Sha <pankajshadev@gmail.com>
Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants