Refactor getUser controller function based on query parameter #2370
+218
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
changed the title
pankajjs
force-pushed
the
refactor/user-controller-2274
branch
from
26351df to
3b2fefe
Compare
Prakhar-FF13
force-pushed
the
refactor/user-controller-2274
branch
from
3b2fefe to
47b8ba9
Compare
…ameters Signed-off-by: Prakhar Kumar <prakhar.meerut@gmail.com>
Signed-off-by: Prakhar Kumar <prakhar.meerut@gmail.com>
Signed-off-by: Prakhar Kumar <prakhar.meerut@gmail.com>
…for reusability. 2. Updated the integration tests after refactoring of code. Signed-off-by: Prakhar Kumar <prakhar.meerut@gmail.com>
Prakhar-FF13
force-pushed
the
refactor/user-controller-2274
branch
from
b733ceb to
220e533
Compare
…ryparam Signed-off-by: Prakhar Kumar <prakhar.meerut@gmail.com>
pankajjs
requested changes
Feb 5, 2025
| return res.json({ | ||
| message: "User returned successfully!", | ||
| user, | ||
| message: user ? "User returned successfully!" : "User not found", |
AnujChhikara
reviewed
Feb 5, 2025
| count: usersData.length, | ||
| users: usersData, | ||
| message: "No users found", | ||
| users: [], |
There was a problem hiding this comment.
why we removed the count field?
| user = result.user; | ||
| if (!result.userExists) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
why are we not throwing error here?
There was a problem hiding this comment.
This is the original functionality haven't changed the code, just refactored it, if i throw error here. Tests will fail as it would require null user but we would return a 404 status code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 26 Jan 2025
Developer Name: Prakhar Kumar
Issue Ticket Number
Description
Refactored get users function in user controller by decomposing into smaller functions based on query parameters.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Test Coverage
Additional Notes
Tejas Sir has asked for a peer review for the PR and then design doc can be discussed.
Design Doc - https://docs.google.com/document/d/19cs4FndY-Rh37A7ptZ2db9S-1Mqd2BICwpWV-SZJQv4/edit?tab=t.0#heading=h.o43h9priqbg
TCR - https://dashboard.realdevsquad.com/task-requests/details/?id=65zapL8S5y4mm9M2bPzC