Add support to send different error response from error handler middleware #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
force-pushed
the
fix/error-handler
branch
2 times, most recently
from
d066364 to
bfac84b
Compare
| @@ -23,12 +23,13 @@ app.use(function (req, res, next) { | |||
| }); | |||
|
|
|||
| // error handler | |||
| app.use(function (err, req, res, next) { | |||
| app.use(function (err, req, res, _next) { | |||
There was a problem hiding this comment.
_next why this change ?
There was a problem hiding this comment.
It is a good practise to prefix the variable with underscore when it is unused in the function but required in function parameter. It also prevents warning.
Considering it, I have added _ before next middleware.
pankajjs
force-pushed
the
fix/error-handler
branch
from
bfac84b to
d892ed0
Compare
mbramani
approved these changes
Feb 6, 2025
Prakhar-FF13
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 26 Jan, 2025
Developer Name: @pankajjs
Issue Ticket Number
Description
This PR fixes the error handler middleware by adding support to send different error responses based on error types.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes