Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in task request details page #618

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Nov 20, 2023

Date: 20 November 2023
Developer Name: @Ajeyakrishna-k


‼️ Please merge the following PR first :


Issue Ticket Number:-

Description:

  • Uncomment the reject button and minor refactors in html.
  • Adds event listener to reject button.
  • Adds a spinner when there's an api call.
  • Updates the status element in page when a status update CTA was called.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

Screen.Recording.2023-11-21.at.2.35.25.PM.mov

Device Responsiveness:

Screen.Recording.2023-11-27.at.10.12.16.AM.mov

Screenshot 2023-11-21 at 2 43 56 PM

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc0a77e
Status: ✅  Deploy successful!
Preview URL: https://37d67b06.dashboard-rds.pages.dev
Branch Preview URL: https://feat-task-requests-details.dashboard-rds.pages.dev

View logs

@Ajeyakrishna-k Ajeyakrishna-k changed the base branch from develop to fix/task-requests-issues November 21, 2023 05:26
@Ajeyakrishna-k Ajeyakrishna-k self-assigned this Nov 22, 2023
@vinit717
Copy link
Member

Can you send the video which works for different screen sizes

@ajoykumardas12
Copy link
Contributor

Does the reject button rejects a particular requester or all requests for that task?
It's not clear from the UI.

@Ajeyakrishna-k
Copy link
Contributor Author

Does the reject button rejects a particular requester or all requests for that task? It's not clear from the UI.

All users request. Design for this page will be improved.

@Ajeyakrishna-k
Copy link
Contributor Author

Can you send the video which works for different screen sizes

done..

ajoykumardas12
ajoykumardas12 previously approved these changes Nov 28, 2023
vinit717
vinit717 previously approved these changes Nov 28, 2023
Base automatically changed from fix/task-requests-issues to develop November 29, 2023 18:58
@prakashchoudhary07 prakashchoudhary07 dismissed stale reviews from vinit717 and ajoykumardas12 November 29, 2023 18:58

The base branch was changed.

@prakashchoudhary07
Copy link
Contributor

Please resolve conflicts

@Ajeyakrishna-k
Copy link
Contributor Author

Please resolve conflicts

Done.

@prakashchoudhary07 prakashchoudhary07 merged commit 8181428 into develop Nov 30, 2023
5 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the feat/task-requests-details branch November 30, 2023 18:23
@Ajeyakrishna-k Ajeyakrishna-k mentioned this pull request Dec 4, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants