Feature: add skills field #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunilk429
force-pushed
the
feature/add-skills-field
branch
2 times, most recently
from
6f4daab to
d3c66e7
Compare
yesyash
requested changes
Nov 28, 2024
sunilk429
force-pushed
the
feature/add-skills-field
branch
2 times, most recently
from
327b65f to
c154dd8
Compare
yesyash
previously approved these changes
Dec 2, 2024
sunilk429
force-pushed
the
feature/add-skills-field
branch
from
c154dd8 to
c541da3
Compare
yesyash
previously approved these changes
Dec 2, 2024
iamitprakash
previously approved these changes
Dec 4, 2024
sunilk429
force-pushed
the
feature/add-skills-field
branch
from
c541da3 to
cf01917
Compare
This PR had conflicts, fixed incorrectly... Will fix it once I am back. Currently I am ooo |
sunilk429
force-pushed
the
feature/add-skills-field
branch
2 times, most recently
from
344edd4 to
540a29a
Compare
sunilk429
force-pushed
the
feature/add-skills-field
branch
from
ba5add9 to
c2b5973
Compare
iamitprakash
requested changes
Dec 24, 2024
iamitprakash
approved these changes
Dec 24, 2024
iamitprakash
added a commit
that referenced
this pull request
Dec 25, 2024
Feature: add skills field (#918) * featureUrl removed * removed feature/group * change class inputBox instead radioButton * task level section removed * unncessary object destruction under featureflag removed * status=available typo fixed * tests added for updated changes * Tests fixed * Added data-testid for testing,also added new tests * Test api updated to staging * refactored for readability * created a constants file * API_BASE_URL changed to stating for testing * Added data-testid for testing,also added new tests * Test api updated to staging * refactored for readability * added skills field * Tests for skills field added * restore accidently deleted css * fixed checkbox styling * fixed (Select aAll) typo and removed repeated code * Added new tests * update query selector to element id * mock skills added for testing * SKILL_TREE_BACKEND_BASE_URL imported from constants Co-authored-by: sunilk429 <160393886+sunilk429@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 20th October, 2024
Developer Name: Sunil Kumar
Issue Ticket Number
Description
Added Skills multi-select component
Depends On
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Recording.2024-11-20.204842.mp4
Test Coverage
Screenshot 1
Additional Notes