Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update development server command #933

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JC-Coder
Copy link

@JC-Coder JC-Coder commented Jan 4, 2025

Date: 04/01/2025

Developer Name: JC-Coder


Issue Ticket Number

Description

update development server command to run the start script and initialize the proxy also to improve development flow

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1 image
Screen.Recording.2025-01-05.at.9.48.01.PM.mov

Test Coverage

Screenshot 1

Additional Notes

…itialize the proxy also to improve development flow
yesyash
yesyash previously approved these changes Jan 5, 2025
@yesyash yesyash self-requested a review January 5, 2025 11:44
@yesyash yesyash dismissed their stale review January 5, 2025 11:46
  • need to verify why the port was changed.
@@ -8,7 +8,7 @@
"fix": "prettier --write .",
"test": "jest",
"start": "node server.js",
"dev": "local-ssl-proxy --source 443 --target 5500 -n dev.realdevsquad.com"
"dev": "node server.js & local-ssl-proxy --source 443 --target 8000 -n dev.realdevsquad.com"
Copy link
Contributor

@yesyash yesyash Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • couple of questions:
    • what does node server.js do?
    • does the server reload the page if we make any changes in the codebase (or) will we have to reload the page manually for the changes to be visible?
    • why are we changing the port from 5500 to 8000?

Copy link
Author

@JC-Coder JC-Coder Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the node server.js is used to start the server
  2. no the server does not reload.
  3. the server.js runs on 8000 by default so we need to also change the target to 8000 so it can resolve the right target . you can look up more on the local-ssl-proxy doc for more example

@vinit717
Copy link
Member

vinit717 commented Jan 5, 2025

Also please add a working screen recording proof

@JC-Coder JC-Coder closed this Jan 5, 2025
@JC-Coder JC-Coder reopened this Jan 5, 2025
@JC-Coder
Copy link
Author

JC-Coder commented Jan 5, 2025

Also please add a working screen recording proof

screenshot added . kindly check

@vinit717
Copy link
Member

vinit717 commented Jan 5, 2025

Also please add a working screen recording proof

screenshot added . kindly check

not the screenshot can you please add a screen recording of the working website at dev and localhost

@JC-Coder
Copy link
Author

JC-Coder commented Jan 5, 2025

Also please add a working screen recording proof

screenshot added . kindly check

not the screenshot can you please add a screen recording of the working website at dev and localhost

video added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants