fix: cursor is pointer when superuser hover over users #470
Conversation
prankurpandeyy
requested review from
sumitd94 and
ankushdharkar
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If this condition is just for super user then, why do other user able to see the pointer icon too? |
|
@Maheima I have fixed the issues which you pointed out yesterday , you can review it. |
| box-shadow: none; | ||
| &:hover { | ||
| box-shadow: none; | ||
| } | ||
| } | ||
| .containerForNewMemberHover { | ||
| @extend .containerForNewMember; |
There was a problem hiding this comment.
Impressive 🙌
Good use of @extend
| @@ -7,7 +7,7 @@ | |||
| } | |||
|
|
|||
| .newUser { | |||
| pointer-events: none; | |||
| pointer-events: auto; | |||
There was a problem hiding this comment.
Isn't the expectation, only super user should perform some action on pointer event and rest shouldn't?
Clarify in case I am thinking wrong here
There was a problem hiding this comment.
Yes anyone with a super user role should be able to have a cursor pointer property for the rest of the users it should be the default cursor pointer.
src/components/new-members/index.js
Outdated
| <div | ||
| className={ | ||
| isSuperUser | ||
| ? styles.containerForNewMemberHover |
There was a problem hiding this comment.
Can you please think of better classnames here? Rest everything looks great!
There was a problem hiding this comment.
Sure, I am changing it to something more meanigful.
closes : #466
Issue :
The cursor is not pointer when super user hovers over new user profile .
Files Changed
index.js
new-members.module.scss
Fixes :
Added the cursor pointer when the superuser hovers on new user profiles.
For better understanding and more reference, Please read the issue ticket: #466
Issue