Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cohere as a provider #125

Merged
merged 2 commits into from
Dec 29, 2024
Merged

feat: add cohere as a provider #125

merged 2 commits into from
Dec 29, 2024

Conversation

sunflsks
Copy link
Contributor

This PR adds Cohere as a supported platform for fish-ai. I believe I covered all my bases here (adding a provider seems very plug and play), but please let me know if there are any changes I should make.

Copy link

Hello @sunflsks. Thank you for contributing to this project! 💛 I'll review your changes when time permits.

By contributing, you agree to the Developer Certificate of Origin and your code being licensed under the MIT license.

If this sounds like greek, please spend a minute or two to read through these documents.

@github-actions github-actions bot added the size/S Pull request with less than 30 lines of code label Dec 29, 2024
@Realiserad Realiserad self-assigned this Dec 29, 2024
@Realiserad Realiserad force-pushed the cohere branch 2 times, most recently from 95e8b3d to dd90486 Compare December 29, 2024 03:30
@Realiserad
Copy link
Owner

Realiserad commented Dec 29, 2024

@sunflsks Made a small change, can you test again to make sure cohere still works? I'll then merge this PR and create a new tag.

There are some failing tests, but except the DCO they are not related to your changes, and will be worked on in a separate PR.

Thank you!

@sunflsks
Copy link
Contributor Author

Yes, it seems to work perfectly.

sunflsks and others added 2 commits December 29, 2024 11:13
Closes: Realiserad#125
Signed-off-by: Bastian Fredriksson <bastian.fredriksson@keyfactor.com>
Signed-off-by: Bastian Fredriksson <bastian.fredriksson@keyfactor.com>
@Realiserad Realiserad merged commit 1a5d695 into Realiserad:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Pull request with less than 30 lines of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants