[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st enhancements batch #933
+3,235
−2,014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
added
bug
enhancement
feature proposal
platform:linuxbsd
platform:ios
platform:windows
topic:core
platform:macos
topic:buildsystem
topic:rendering
topic:editor
topic:porting
usability
topic:thirdparty
topic:audio
topic:xr
topic:import
topic:input
topic:gui
topic:navigation
topic:animation
topic:export
performance
topic:particles
labels
In future work we may want to expose an isStylus or similar for XR Trackers, though that is likely outside the scope of this commit which is the core extension work. Vendor Ref: https://logitech.github.io/mxink/OpenXR.html (cherry picked from commit 19c7afe)
(cherry picked from commit 443da32)
(cherry picked from commit 3156856)
(cherry picked from commit d222921)
(cherry picked from commit 761a20f)
(cherry picked from commit 41875d8)
(cherry picked from commit db4672f)
(cherry picked from commit 4ac1f9c)
(cherry picked from commit cfb7443)
This applies both to tangents and general line drawing, making the animation Bezier editor match the Curve editor inspector. (cherry picked from commit ef35ca2)
Keep support for major 17 by using a version check for the changed API. Fixes #93907. (cherry picked from commit 4c72d59)
This is useful information to know, as the X11 display driver can be used both on X11 natively and on Wayland through XWayland. Certain editor issues only occur in multi-window mode (or only in single-window mode). Some issues also only occur on multi-monitor setups, so the monitor count is now listed. (cherry picked from commit 107675f)
(cherry picked from commit 7aef30c)
(cherry picked from commit d222daa)
(cherry picked from commit acab2d6)
(cherry picked from commit 1b0c5cb)
(cherry picked from commit 4f8dd96)
(cherry picked from commit 8d1462c)
(cherry picked from commit a5f86ee)
(cherry picked from commit ed7b4f5)
Synced with mdqinc/SDL_GameControllerDB@cfc2bff (cherry picked from commit f2d58f5)
(cherry picked from commit d471210)
…nvendored builds This restriction was added to fix #7373 back then, which was a symbol conflict between FreeType's bundled copy of gzip/zlib, and distro packages. But we also unbundled FreeType's zlib in #69395 so this is no longer an issue. On the other hand recent issues pointed out that using system-provided icu4c or harfbuzz can cause issues (#91401, #100301). We still allow it for now but raise a warning. (cherry picked from commit 7fe0609)
It seems that we are only enabling this option together with unsafe build determinators. However it seems that MD5-timestamp by itself is not unsafe. MD5-Timestamp works by first checking the timestamp of a file, comparing it to the scons database and if it does not match it will do an md5sum to determine if the file needs rebuilding. Without this option SCons will always create md5sums of every file. In the case of a null build this is 50% of the time. (cherry picked from commit 04fff3f)
When profiling Dome Keeper, I found that in physics_process a HashMap gets cleared a lot, which ends up calling the Variant destructor. Calling Variant::clear() dominates this operation. By not uselessly setting the Type to NIL on destruction we save about 50% of time. This is likely because if there is a simple type in the Variant that doesn't need destructing, but now we write when we should just drop the Variant altogether. Since the value of Variant::type should be unobservable after destruction this doesn't change any outward behavior. (cherry picked from commit 46c23e1)
By making sure that Thread always has a valid caller_id we can remove the check making the function a straightforward getter instead. In some quick tests we see a repeatable performance improvement of somewhere around 0.32 mspf in TPS demo. Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com> (cherry picked from commit 873eb21)
Spartan322
force-pushed
the
4.3.1-cherry-pick/enhancements
branch
from
5256266 to
907619a
Compare
decryptedchaos
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement PRs:
get_bounds()function to NavigationMeshSourceGeometryData godotengine/godot#95137AnimationMixergodotengine/godot#95711TranslationServer.compare_locales()godotengine/godot#98236env.Decider("MD5-timestamp")godotengine/godot#100210Variant::Typein destructor godotengine/godot#100795Thread::get_caller_id()godotengine/godot#101072Extra PRs: