[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st gdextension bugs batch #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c8a0766)
Attempt to grab the icon for a script type from the theme first, then ask the extension for the icon. (cherry picked from commit 5da3e81)
(cherry picked from commit 2599df3)
…xtension (cherry picked from commit ca12f35)
…_get_bar_beats()` (cherry picked from commit 3866a7f)
…ata()` (cherry picked from commit 8c01fc2)
SkogiB
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDExtension Bug PRs:
CompositorEffectshould useGDVIRTUAL_CALL()so it works with GDExtension godotengine/godot#99981GDVIRTUAL_BIND()forAudioStream::_has_loop()and::_get_bar_beats()godotengine/godot#100126StreamPeerExtension::put_partial_data()to call_put_partial_data()godotengine/godot#100318Extra PRs: