Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st rendering bugs batch #942

Merged
merged 24 commits into from
Jan 23, 2025
Merged

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st rendering bugs batch #942

merged 24 commits into from
Jan 23, 2025

Conversation

Spartan322
Copy link
Member

Rendering Bug PRs:

ecmjohnson and others added 24 commits January 22, 2025 13:11
@ecmjohnson @Spartan322
Fix volumetric fog artifacts when inside the fog
6115712 
(cherry picked from commit 532630e)
@Carbonyte @Spartan322
Check device texture size limits in RenderingDevice::texture_create
eac621a 
(cherry picked from commit 16ee2f2)
@BastiaanOlij @Spartan322
Fix compatibility canvas background depth issue
6788299 
(cherry picked from commit 491a5d9)
@jj11hh @Spartan322
Fix hash calculation for NTSliceKey
38d92de 
A bug was introduced from 057367b by adding FSR 2.2.1 support.
Which increases hash collision and hurts performance.

(cherry picked from commit 864d4fb)
@patowen @Spartan322
Clamp UV-coordinates to centers of outermost texels when configured t…
090d65d 
…o do so

In addition, fix region_filter_clip_enabled documentation to be consistent with AtlasTexture.xml, since that is the option whose behavior was fixed

(cherry picked from commit d720eb8)
@clayjohn @Spartan322
Improve the look of radiance map in Compatibility backend
cd36b77 
(cherry picked from commit 4f67415)
@huwpascoe @Spartan322
Lightmap Dynamic Bugfix
cd6e3a8 
(cherry picked from commit 274076c)
@m-pranav-r @Spartan322
Fix incorrect depth comparison used to calculate volumetric fog shado…
16efbfe 
…wing

(cherry picked from commit c12001a)
@m-pranav-r @Spartan322
Fixed light culling mask behavior in Mobile and Compat renderers
7e44ddf 
(cherry picked from commit fcea158)
@Gromph @Spartan322
Fix window exiting with no message to user if _create_window fails
b1883f9 
(cherry picked from commit 403e53e)
@ydeltastar @Spartan322
Fix MultiMesh errors in editor and resource duplication
f871a0b 
(cherry picked from commit cb94652)
@jadeharley2 @Spartan322
Fix inability to set TextureLayeredRD as TEXTURE_TYPE_CUBE or TEXTURE…
0ddf3cf 
…_TYPE_CUBE_ARRAY

(cherry picked from commit a4d1d36)
@clayjohn @Spartan322
Normalize normal tangent and binormal before interpolating in the mob…
649a263 
…ile renderer to avoid precision errors on heavily scaled meshes

(cherry picked from commit 2c158c3)
@Flarkk @Spartan322
Fix SSS with reverse-z
956a548 
(cherry picked from commit 3376b91)
@BlueCube3310 @Spartan322
Fix updating lightmap captures on Mobile
9254e2a 
(cherry picked from commit bb3d004)
@jamie-pate @Spartan322
Fix gl_compatibility lightmap uniforms not being set
cb7d88d 
Fixes #99592

The following variables were set too early, and later code never ran..
prev_shader, prev_variant, prev_spec_constants variables

These variables were shared in two different branch conditions but were
updated inside the first one, so the second could never be true..

The condition to update lighting also should check prev_spec_constants
since it updates that uniform.

(cherry picked from commit 45a7bcc)
@lander-vr @Spartan322
Fix ReflectionProbe AABB
60b83b0 
(cherry picked from commit 11225de)
@alessand10 @Spartan322
Fix a command buffer leak that occurs in dx12
5b5723e 
(cherry picked from commit 9ea97c0)
@Namey5 @Spartan322
fix: canvas background mode not clearing correctly when using gles3 g…
197be68 
…low effect

(cherry picked from commit 830f250)
@Namey5 @Spartan322
fix: crash in scenes with more than 8 shadowed directional lights
a0b8df5 
(cherry picked from commit 34ebec3)
@brandon515 @Spartan322
Implemented fix from #91219 in compatibility renderer by reversing the z
e9b781c 
axis in the particle shader.

(cherry picked from commit 9906120)
@BlueCube3310 @Spartan322
Web: Export ASTC/BPTC compressed textures
832f0b3 
(cherry picked from commit 84e6ac9)
@clayjohn @Spartan322
Correct aspect ratio used in FSR2 calculations to remove a source of …
af59e74 
…depth-based ghosting

(cherry picked from commit 25a9b04)
@DarioSamo @Spartan322
Fix duplicated spec constant on SPIR-V reflection.
ece864e 
(cherry picked from commit 1af1edf)
@Spartan322 Spartan322 merged commit 6c1f04b into Redot-Engine:4.3 Jan 23, 2025
18 checks passed
@Spartan322 Spartan322 deleted the 4.3.1-cherry-pick/bugs-rendering branch January 23, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkogiB SkogiB SkogiB approved these changes

@tindrew tindrew tindrew approved these changes

Assignees
No one assigned
Labels
bug platform:web platform:windows topic:editor topic:import topic:particles topic:porting topic:rendering topic:2d topic:3d
Projects
Engine Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.