Implement logging for debug adapter clients (#45)

* Implement RPC logging for debug adapter clients

* Implement server logs for debugger servers

* This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields.  I also removed some specific when has logs from the client, because the client is not responsible for that.  Removed an not needed/duplicated dependency  Fix formatting & clippy

This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields.

I also removed some specific when has logs from the client, because the client is not responsible for that.

Removed an not needed/duplicated dependency

Fix formatting & clippy

* Implement `has_adapter_logs` for each transport impl

* Make adapter stdout logging work

* Add conditional render for adapter log back

* Oops forgot to pipe the output

* Always enable rpc messages

Previously, RPC messages were only stored when explicitly enabled, which occurred after the client was already running. This approach prevented debugging of requests sent during the initial connection period. By always enabling RPC messages, we ensure that all requests, including those during the connection phase, are captured and available for debugging purposes.

This could help use debug when someone has troble getting a debug starting. This improvement could be particularly helpful in debugging scenarios where users encounter issues during the initial connection or startup phase of their debugging sessions.

---------

Co-authored-by: Remco Smits <djsmits12@gmail.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>

Cargo.toml

@@ -172,6 +172,7 @@ members = [
     #
 
     "tooling/xtask",
+    "crates/debugger_tools",
 ]
 default-members = ["crates/zed"]
 
@@ -207,6 +208,7 @@ dap = { path = "crates/dap" }
 dap_adapters = { path = "crates/dap_adapters" }
 db = { path = "crates/db" }
 debugger_ui = { path = "crates/debugger_ui" }
+debugger_tools = { path = "crates/debugger_tools" }
 dev_server_projects = { path = "crates/dev_server_projects" }
 diagnostics = { path = "crates/diagnostics" }
 editor = { path = "crates/editor" }

crates/dap/Cargo.toml

@@ -18,9 +18,11 @@ gpui.workspace = true
 http_client.workspace = true
 log.workspace = true
 node_runtime.workspace = true
+parking_lot.workspace = true
 schemars.workspace = true
 serde.workspace = true
 serde_json.workspace = true
 settings.workspace = true
+smallvec.workspace = true
 smol.workspace = true
 task.workspace = true

crates/dap/src/adapters.rs

@@ -6,7 +6,6 @@ use http_client::HttpClient;
 use node_runtime::NodeRuntime;
 use serde_json::Value;
 use std::{collections::HashMap, ffi::OsString, path::Path, sync::Arc};
-
 use task::DebugAdapterConfig;
 
 pub trait DapDelegate {

crates/dap/src/client.rs

@@ -1,8 +1,9 @@
 use crate::{
     adapters::{DebugAdapter, DebugAdapterBinary},
-    transport::TransportDelegate,
+    transport::{IoKind, LogKind, TransportDelegate},
 };
 use anyhow::{anyhow, Result};
+
 use dap_types::{
     messages::{Message, Response},
     requests::Request,
@@ -163,4 +164,15 @@ impl DebugAdapterClient {
     pub async fn shutdown(&self) -> Result<()> {
         self.transport_delegate.shutdown().await
     }
+
+    pub fn has_adapter_logs(&self) -> bool {
+        self.transport_delegate.has_adapter_logs()
+    }
+
+    pub fn add_log_handler<F>(&self, f: F, kind: LogKind)
+    where
+        F: 'static + Send + FnMut(IoKind, &str),
+    {
+        self.transport_delegate.add_log_handler(f, kind);
+    }
 }