Re-Apply Lazy load stack frame information #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 27b6043.
This reverts commit 3cf9658.
This was introduced by my original PR, because I added the fetch on stack frame select but when the stack frames where updated we would already fetch the initial variables. And when the selectedStackFrameUpdated event was received we would refetch it because it was not done yet.
The issue was the we used the scope_id, which changes after each debug step. So using the name of the scope instead should be more reliable.
RemcoSmitsDev
force-pushed
the
lazy-load-stack-frame-information
branch
from
0eee6e6 to
df3b209
Compare
Also commenting out an event that triggers the infinite loop. We want to revisited the collab stuff anyway so we decided to do it this way.
RemcoSmitsDev
force-pushed
the
lazy-load-stack-frame-information
branch
from
df3b209 to
dfd2498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-applies #106:
This PR changes when we fetch scopes & variables for a stack frame. Before this change, we would always fetch all the scopes & top level variables for all the stack frames. But this leads to a slow experience when you have a debug session that has a lot of stack frames. Not only that, but for example the JavaScript debugger allows you to visually skip stack frames, which why it does not make sense to fetch the scopes and variables for them only when you actually want to see them.
So this PR changes that, we now always only fetch the scopes & variables for the first stack frame and when a user selects a stack frame for the first time we will fetch the information after that we will only rebuild the visual entries everytime.
This PR fixes the following things:
TODO's