Implement Attach debugger + picker #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client should always be there at this point.
While debugging an reverse request issue, the top level client did send terminated event with `restart: false` but we tried to restart the client resulting in the client never being cleaned up by us. Because before this change we always assumed if we got a json value we are going to restart the client, which is wrong. We no try to restart the client if: - restart arg is a boolean and its true - restart arg is a json value but no boolean
RemcoSmitsDev
force-pushed
the
debugger
branch
from
8f03dc6 to
cd2b4a8
Compare
It would be cool if we could show the error message directly within |
This changes debug.json to look for adapter: adapter_name instead of and object when a user selects a debug adatper and fixes the default behavior of request (to launch) Co-authored-by: Remco Smits <djsmits12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-30.at.20.37.57.mov
Todo
startDebuggingwas handled