Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collab: Sync breakpoints #68

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Collab: Sync breakpoints #68

merged 12 commits into from
Nov 25, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Nov 20, 2024

Screen.Recording.2024-11-19.at.23.08.20.mov

Todo

  • Sync breakpoints on breakpoint toggle
  • Sync breakpoints on project share/join
    • Sync breakpoints when someone connects after you setting your first breakpoint

@RemcoSmitsDev RemcoSmitsDev force-pushed the collab-sync-breakpoints branch from 828766a to e73d3c9 Compare November 20, 2024 15:17
We now send SynchronizedBreakpoints within the JoinProjectResponse
and use those breakpoints to initialize a remote DapStore.
@Anthony-Eid Anthony-Eid marked this pull request as ready for review November 25, 2024 13:35
@Anthony-Eid
Copy link
Collaborator

I think this is ready to be merged!

@RemcoSmitsDev RemcoSmitsDev merged commit 2c45c57 into debugger Nov 25, 2024
9 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the collab-sync-breakpoints branch November 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants