Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework download adapters and allow multiple download formats #72

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Dec 4, 2024

This PR fixes the following issues:

  • JavaScript adapter could not be compiled on the fly.
    • We now download a prebuild version of the adapter instead of installing dependencies and building the adapter ourself.
  • PHP(xdebug) adapter could not be compiled on the fly.
    • We now download a prebuild version of the adapter instead of installing dependencies and building the adapter ourself.
  • When the cached binary is corrupt or adapter was removed, you had to restart Zed to use the adapter again.
    • We now fall back to just try to install the latest version again, which should fix/cover most cases.

TODO:

  • Add override binary pah again, but don't let each adapter handle how to use the override binary path

@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review December 6, 2024 19:30
@RemcoSmitsDev RemcoSmitsDev merged commit 2b8ae36 into debugger Dec 6, 2024
10 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the rework-download-adapters branch February 8, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants