Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAP Step back support #78

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

Anthony-Eid
Copy link
Collaborator

Release Notes:

  • When debugging with a DAP that supports step back Zed will now show a step button button

The step back button is hidden because most dap implementations don't support
it.
@Anthony-Eid Anthony-Eid changed the base branch from main to debugger December 19, 2024 17:35
@Anthony-Eid Anthony-Eid marked this pull request as ready for review December 19, 2024 17:39
@RemcoSmitsDev
Copy link
Owner

Great work btw! But I think we also have to add a listener inside debugger_ui/lib so you can also use the action.

@Anthony-Eid
Copy link
Collaborator Author

@RemcoSmitsDev I don't think we should be setting the thread status before sending stepping requests on button clicks. If the request fails there's no way for a user to click on a button because they'll be disabled. We should set the thread status on receiving a positive response or reset the thread status when receiving a failed response (I like the second idea).

This is something I ran into when testing the step back button for a DAP that doesn't support it, so I wanted to mention it here. It's scope is different than this PR so we should make a separate PR to address this issue.

@RemcoSmitsDev
Copy link
Owner

Yeah, that is something we have to think about, I like the idea of making it disabled, so the user cannot spam the buttons and that we give early feedback to the user about the action he did. So changing the status back when we receive an error from these actions would be a great solution to fix this.

@Anthony-Eid Anthony-Eid merged commit 1b1d374 into RemcoSmitsDev:debugger Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants