Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug output grouping #86

Merged
merged 13 commits into from
Jan 14, 2025
Merged

Debug output grouping #86

merged 13 commits into from
Jan 14, 2025

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Jan 12, 2025

Screen.Recording.2025-01-14.at.18.58.43.mov

Info

This PR removes the output editor view, in favor of the debug console, so it's more clear where the output will be.
Because before this change, the output could be redirected to the debug console or the output editor view. Which already confused a few people, so merging them together makes more sense, as there is also not a reason to keep them separate.

But the main goal of this PR was to introduce the output grouping feature that the dap protocol supports, as some people gave feedback some time ago that the output must be displayed in a better way. So, starting by supporting grouped output, will take a step in the right direction to improve the display of the debug output console.

TODO's

  • Add tests
  • See if we could decrease the gutter width
  • Remove the OutputGroup state when we know the end position, so we don't have to store it in memory as we don't use it anymore after it.

Example code for JavaScript

console.log("This is the outer level");
console.group();
console.log("Level 2");
console.group();
console.log("Level 3");
console.warn("More of level 3");
console.groupEnd();
console.log("Back to level 2");
console.groupEnd();
console.log("Back to the outer level");
console.groupCollapsed();
console.log("Level 2");
console.groupEnd();

@RemcoSmitsDev RemcoSmitsDev merged commit 8ecd547 into debugger Jan 14, 2025
11 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the output-grouping branch January 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant