Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack frame presentation hint #94

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

RemcoSmitsDev
Copy link
Owner

Screen.Recording.2025-01-20.at.19.01.53.mov

This PR implements the first part of acting on the stack frame presentation hint. The first part is to add the collapsed stack frames feature, this will show stack frames that are ignored by an adapter with a placeholder that you could expand.

We decided to not implement this for collab, because we are going to implement the followable item soon.
So that will include that so we sync it better for host & clients. You can already toggle the collapsed stack frames on the guest side, tho, because we handle this on the client side.

@RemcoSmitsDev RemcoSmitsDev force-pushed the stack-frame-presentation-hint branch from 4f9a6f3 to d04f4ba Compare January 20, 2025 19:34
@RemcoSmitsDev RemcoSmitsDev merged commit 7b6d20b into debugger Jan 20, 2025
10 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the stack-frame-presentation-hint branch January 20, 2025 19:34
@Anthony-Eid
Copy link
Collaborator

I'm probably going to revisit this to make it so we don't send scope requests to stack frames that are collapse. They're usually a waste and it's making lldb-dap logs hard to read from our end.

@RemcoSmitsDev
Copy link
Owner Author

That has not really anything to do with this pr, right? Except that we now collapse them, we could fetch all the scopes/variables when you expand them.

@RemcoSmitsDev
Copy link
Owner Author

But in general we can just fetch the scopes/variables when you click on a stack frame that has no scopes/variables attached to it.

@RemcoSmitsDev
Copy link
Owner Author

except for the first one

@Anthony-Eid
Copy link
Collaborator

But in general we can just fetch the scopes/variables when you click on a stack frame that has no scopes/variables attached to it.

I like this idea the most.

I made the comment in this PR because it’s in the same realm of what this PR changed. I have no intentions of editing this PR though, I would just make a new one

@RemcoSmitsDev
Copy link
Owner Author

Ahh oke got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants