Add support for Python attach feature

crates/dap_adapters/src/python.rs

@@ -1,7 +1,12 @@
 use crate::*;
-use dap::transport::{TcpTransport, Transport};
+use dap::{
+    transport::{TcpTransport, Transport},
+    DebugRequestType,
+};
 use gpui::AsyncApp;
-use std::{ffi::OsStr, net::Ipv4Addr, path::PathBuf, sync::Arc};
+use regex::Regex;
+use std::{collections::HashMap, ffi::OsStr, net::Ipv4Addr, path::PathBuf, sync::Arc};
+use sysinfo::{Pid, Process};
 
 pub(crate) struct PythonDebugAdapter {
     port: u16,
@@ -131,10 +136,45 @@ impl DebugAdapter for PythonDebugAdapter {
     }
 
     fn request_args(&self, config: &DebugAdapterConfig) -> Value {
-        json!({
+        let pid = if let DebugRequestType::Attach(attach_config) = &config.request {
+            attach_config.process_id.filter(|pid| *pid > 0)
+        } else {
+            None
+        };
+
+        let mut config = json!({
+            "request": match config.request {
+                DebugRequestType::Launch => "launch",
+                DebugRequestType::Attach(_) => "attach",
+            },
+            "processId": pid,
             "program": config.program,
             "subProcess": true,
             "cwd": config.cwd,
-        })
+        });
+
+        if let Value::Object(config) = &mut config {
+            config.retain(|_, v| !v.is_null());
+        }
+
+        config
+    }
+
+    fn supports_attach(&self) -> bool {
+        true
+    }
+
+    fn attach_processes<'a>(
+        &self,
+        processes: &'a HashMap<Pid, Process>,
+    ) -> Option<Vec<(&'a Pid, &'a Process)>> {
+        let regex = Regex::new(r"(?i)^(?:python3|python|py)(?:$|\b)").unwrap();
+
+        Some(
+            processes
+                .iter()
+                .filter(|(_, process)| regex.is_match(&process.name().to_string_lossy()))
+                .collect::<Vec<_>>(),
+        )
     }
 }

docs/src/debugger.md

@@ -62,7 +62,7 @@ To create a custom debug configuration you have to create a `.zed/debug.json` fi
 
 ### Using Attach [WIP]
 
-Only javascript and lldb supports starting a debug session using attach.
+Only JavaScript, Python and lldb supports starting a debug session using attach.
 
 When using the attach request with a process ID the syntax is as follows: