WIP: Another Toolchain integration #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
adapter config now has workspace_id that is resolved with the task based off of the cwd. I also gave dap delegate to an AsyncAppContext so it's able to query the toolchain store without dap store doing it for the delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch of PR #90 because we both worked on it at the same time without realizing and now we have two different implementations.
@RemcoSmitsDev I'm hoping we can talk about this tomorrow. This should clean up a lot of the problems we've had with my last implementation, and we don't have to expose AppContext to the dap_adapter trait