Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #428: Otp column missing issue resolved #429

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

prajwal2431
Copy link
Contributor

@prajwal2431 prajwal2431 commented Jan 1, 2025

📋 Description

Fixes: #428
This PR adds an OTP functionality to the user login system. It ensures users receive a one-time password for verification during login. Due to missing column otp this causes some issue which is resolved now

🔨 Changes Made

  • Added otp column to user_table for OTP storage.
  • Implement the notification function to send the notification

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidlines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛

  • New feature (non-breaking change which adds functionality) ✨

  • UI enhancement (non-breaking change which enhances UI) 🎨

  • Documentation update 📚

  • Fixes ##

📸 Screenshots (if applicable)


Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @prajwal2431 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Member

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other queries are returning error where the insertion have been done. You have to add an extra column in signup function to avoid any errors-
ERROR 1136 (21S01): Column count doesn't match value count at row 1

you can send null value in the insertion query. Also test your changes with other functionalities

image

@@ -14,7 +14,8 @@ CREATE TABLE user_table (
userid INT AUTO_INCREMENT UNIQUE PRIMARY KEY,
username VARCHAR(60) NOT NULL,
email VARCHAR(80) NOT NULL UNIQUE,
password VARCHAR(140) NOT NULL UNIQUE
password VARCHAR(140) NOT NULL UNIQUE,
otp VARCHAR(6) -- Add the otp column to store OTP values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add default null property in otp column

@prajwal2431
Copy link
Contributor Author

Ohh yeah sure will make that

@prajwal2431
Copy link
Contributor Author

Now you can review once again

@Harshdev098 Harshdev098 merged commit 4236424 into Research-Nexas:main Jan 2, 2025
1 check passed
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🎉🎉 Thank you for your contribution! Your PR #429 has been merged! 🎉🎉

@Harshdev098 Harshdev098 added SWoC Under Social winter of code INTERMEDIATE labels Jan 2, 2025
@Harshdev098
Copy link
Member

@prajwal2431 please register yourself in os lead so that we can assign your points

@prajwal2431
Copy link
Contributor Author

And how to do it

@Harshdev098
Copy link
Member

I think SWoC team have just mailed every contributors about this you can approach to them regarding it

@Harshdev098
Copy link
Member

@prajwal2431 Have you done it

@prajwal2431
Copy link
Contributor Author

Minor changes left will make pr today at 9pm

@Harshdev098
Copy link
Member

Actually I am talking about the oslead application
Have you registered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SWoC Under Social winter of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Otp column missing issue
2 participants