-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #428: Otp column missing issue resolved #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @prajwal2431 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other queries are returning error where the insertion have been done. You have to add an extra column in signup function to avoid any errors-
ERROR 1136 (21S01): Column count doesn't match value count at row 1
you can send null value in the insertion query. Also test your changes with other functionalities
config/dbQuery.sql
Outdated
@@ -14,7 +14,8 @@ CREATE TABLE user_table ( | |||
userid INT AUTO_INCREMENT UNIQUE PRIMARY KEY, | |||
username VARCHAR(60) NOT NULL, | |||
email VARCHAR(80) NOT NULL UNIQUE, | |||
password VARCHAR(140) NOT NULL UNIQUE | |||
password VARCHAR(140) NOT NULL UNIQUE, | |||
otp VARCHAR(6) -- Add the otp column to store OTP values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add default null property in otp column
Ohh yeah sure will make that |
Now you can review once again |
🎉🎉 Thank you for your contribution! Your PR #429 has been merged! 🎉🎉 |
@prajwal2431 please register yourself in os lead so that we can assign your points |
And how to do it |
I think SWoC team have just mailed every contributors about this you can approach to them regarding it |
@prajwal2431 Have you done it |
Minor changes left will make pr today at 9pm |
Actually I am talking about the oslead application |
📋 Description
Fixes: #428
This PR adds an OTP functionality to the user login system. It ensures users receive a one-time password for verification during login. Due to missing column otp this causes some issue which is resolved now
🔨 Changes Made
otp
column touser_table
for OTP storage.✅ Checklist
Before submitting the PR, please make sure you have completed the following:
🏷️ Types of Changes
What type of changes does your code introduce? (Check all that apply)
Bug fix (non-breaking change which fixes an issue) 🐛
New feature (non-breaking change which adds functionality) ✨
UI enhancement (non-breaking change which enhances UI) 🎨
Documentation update 📚
Fixes ##
📸 Screenshots (if applicable)
Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!