-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 423: Otp Functionality enhancement with SQL Events #432
Conversation
…into enhance_otp_function
…/Research-Nexas into enhance_otp_function
@Harshdev098 Please review this PR, apologize for the previous issue, and update me on any changes. |
@prajwal2431 I have updated the query now you can update the logic of the backend. And thanks for your patience actually i got busy with my semester exams |
Means what I have to do it now |
Just update the backend logics because I have removed the attributes in queries for expiration and creation and just used the events |
The field "otp_generated_time" you created in the event should also be included in the table. So, the only change is that you renamed the variable.right? |
Actually you have included |
Will see it once more time will update you in a while |
🎉🎉 Thank you for your contribution! Your PR #432 has been merged! 🎉🎉 |
📋 Description
Fix Issue #423
This PR introduces several key improvements, including the addition of an OTP generator module with automatic OTP generation, the implementation of OTP expiration functionality, and the integration of a timer in the UI to show remaining OTP validity. Additionally, the PR resolves an issue with the /resetpassword endpoint, renaming it to /reset. It also addresses a bug where repeated OTPs were sent in quick succession by implementing rate-limiting logic.
🔨 Changes Made
Added an OTP generator module for automatic OTP generation.
Implemented OTP expiration functionality to restrict OTP validity to a specific time period.
Integrated a timer in the UI to display the remaining time before OTP expiration.
Resolved the /resetpassword endpoint issue by renaming it to /reset to follow proper naming conventions.
Fixed database issues related to OTP generation and expiration, ensuring smooth functionality under extreme conditions.
Prevented repeated OTP sending by introducing rate-limiting logic.
✅ Checklist
Before submitting the PR, please make sure you have completed the following:
I have followed all the guidelines mentioned in CONTRIBUTING.md.
My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation (if applicable).
I have tested it locally and it works fine.
Any dependent changes have been merged and published in downstream modules.
🏷️ Types of Changes
What type of changes does your code introduce? (Check all that apply)
Bug fix (non-breaking change which fixes an issue) 🐛
[] New feature (non-breaking change which adds functionality) ✨
UI enhancement (non-breaking change which enhances UI) 🎨
Documentation update 📚
Fixes #423