v1/common/broker.go: add read lock for registerdTaskNames (#623)

RichardKnop · Nov 21, 2020 · b078943 · b078943
1 parent 3965cbf
commit b078943
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/v1/common/broker.go b/v1/common/broker.go
@@ -75,6 +75,8 @@ func (b *Broker) SetRegisteredTaskNames(names []string) {
 
 // IsTaskRegistered returns true if the task is registered with this broker
 func (b *Broker) IsTaskRegistered(name string) bool {
+	b.registeredTaskNames.RLock()
+	defer b.registeredTaskNames.RUnlock()
 	for _, registeredTaskName := range b.registeredTaskNames.items {
 		if registeredTaskName == name {
 			return true
@@ -118,7 +120,10 @@ func (b *Broker) StopConsuming() {
 
 // GetRegisteredTaskNames returns registered tasks names
 func (b *Broker) GetRegisteredTaskNames() []string {
-	return b.registeredTaskNames.items
+	b.registeredTaskNames.RLock()
+	defer b.registeredTaskNames.RUnlock()
+	items := b.registeredTaskNames.items
+	return items
 }
 
 // AdjustRoutingKey makes sure the routing key is correct.