Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS SQS Visibility Heartbeat Feature #830

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jbret89
Copy link

@jbret89 jbret89 commented Jan 21, 2025

This pull request introduces a new feature to support SQS visibility heartbeat in the machinery project. The main changes include:

  • New Configuration Option: Added VisibilityHeartBeat to enable/disable the visibility heartbeat.
  • Mock Implementation: Created a mock for sqsiface.SQSAPI using testify/mock.
  • Unit Tests: Added tests to assert the number of calls to ChangeMessageVisibility.
  • Code Refactoring: Refactored code to integrate the new feature.

Changes

  • Added VisibilityHeartBeat configuration option.
  • Implemented MockSQSAPI for testing.
  • Updated unit tests.
  • Refactored codebase.

Testing

  • Verified ChangeMessageVisibility method calls.
  • Ensured all existing tests pass.

Documentation

  • Updated configuration documentation to include VisibilityHeartBeat.

This feature aims to improve message processing reliability by periodically extending the visibility timeout of in-flight messages, preventing other consumers from processing the same message simultaneously and avoiding duplicate consumption.

@jbret89 jbret89 changed the title Add SQS Visibility Heartbeat Feature Add AWS SQS Visibility Heartbeat Feature Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant