Increased default max resend attempts for reliable messages to withst…

…and much higher loss rates
RiptideNetworking · Jun 18, 2021 · 82c06f8 · 82c06f8
1 parent 0b234a7
commit 82c06f8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/Demos/Unity/Client/Assets/Scripts/Multiplayer/RiptideNetworking.dll b/Demos/Unity/Client/Assets/Scripts/Multiplayer/RiptideNetworking.dll
diff --git a/Demos/Unity/Server/Assets/Scripts/Multiplayer/RiptideNetworking.dll b/Demos/Unity/Server/Assets/Scripts/Multiplayer/RiptideNetworking.dll
diff --git a/RiptideNetworking/RiptideNetworking/Client.cs b/RiptideNetworking/RiptideNetworking/Client.cs
@@ -208,7 +208,7 @@ internal override void ReliableHandle(byte[] data, IPEndPoint fromEndPoint, Head
         /// <summary>Sends a message to the server.</summary>
         /// <param name="message">The message to send.</param>
         /// <param name="maxSendAttempts">How often to try sending a reliable message before giving up.</param>
-        public void Send(Message message, byte maxSendAttempts = 3)
+        public void Send(Message message, byte maxSendAttempts = 15)
         {
             if (message.SendMode == MessageSendMode.unreliable)
                 Send(message.Bytes, message.WrittenLength, remoteEndPoint);
@@ -332,7 +332,7 @@ internal void SendWelcomeReceived()
             Message message = Message.CreateInternal(HeaderType.welcome);
             message.Add(Id);
 
-            Send(message, 5);
+            Send(message, 25);
         }
 
         /// <summary>Handles a client connected message.</summary>

diff --git a/RiptideNetworking/RiptideNetworking/Server.cs b/RiptideNetworking/RiptideNetworking/Server.cs
@@ -239,7 +239,7 @@ private ushort GetAvailableClientId()
         /// <param name="message">The message to send.</param>
         /// <param name="toClient">The client to send the message to.</param>
         /// <param name="maxSendAttempts">How often to try sending a reliable message before giving up.</param>
-        public void Send(Message message, ServerClient toClient, byte maxSendAttempts = 3)
+        public void Send(Message message, ServerClient toClient, byte maxSendAttempts = 15)
         {
             if (message.SendMode == MessageSendMode.unreliable)
                 Send(message.Bytes, message.WrittenLength, toClient.remoteEndPoint);
@@ -250,7 +250,7 @@ public void Send(Message message, ServerClient toClient, byte maxSendAttempts =
         /// <summary>Sends a message to all conected clients.</summary>
         /// <param name="message">The message to send.</param>
         /// <param name="maxSendAttempts">How often to try sending a reliable message before giving up.</param>
-        public void SendToAll(Message message, byte maxSendAttempts = 3)
+        public void SendToAll(Message message, byte maxSendAttempts = 15)
         {
             lock (clients)
             {
@@ -271,7 +271,7 @@ public void SendToAll(Message message, byte maxSendAttempts = 3)
         /// <param name="message">The message to send.</param>
         /// <param name="exceptToClient">The client NOT to send the message to.</param>
         /// <param name="maxSendAttempts">How often to try sending a reliable message before giving up.</param>
-        public void SendToAll(Message message, ServerClient exceptToClient, byte maxSendAttempts = 3)
+        public void SendToAll(Message message, ServerClient exceptToClient, byte maxSendAttempts = 15)
         {
             lock (clients)
             {
@@ -362,7 +362,7 @@ private void SendClientConnected(IPEndPoint endPoint, ushort id)
             lock (clients)
                 foreach (ServerClient client in clients.Values)
                     if (!client.remoteEndPoint.Equals(endPoint))
-                        Send(message, client, 5);
+                        Send(message, client, 25);
         }
 
         /// <summary>Sends a client disconnected message.</summary>
@@ -374,7 +374,7 @@ private void SendClientDisconnected(ushort id)
 
             lock (clients)
                 foreach (ServerClient client in clients.Values)
-                    Send(message, client, 5);
+                    Send(message, client, 25);
         }
         #endregion
 

diff --git a/RiptideNetworking/RiptideNetworking/ServerClient.cs b/RiptideNetworking/RiptideNetworking/ServerClient.cs
@@ -121,7 +121,7 @@ internal void SendWelcome()
             Message message = Message.CreateInternal(HeaderType.welcome);
             message.Add(Id);
 
-            server.Send(message, this, 5);
+            server.Send(message, this, 25);
         }
 
         /// <summary>Handles a welcome message.</summary>