Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to pnpm #2428

Draft
wants to merge 67 commits into
base: master
Choose a base branch
from
Draft

Switching to pnpm #2428

wants to merge 67 commits into from

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 21, 2025 •
edited
Loading

Reiterating #2067
Based on the findings of #2427
And using the advantage of having workspaces introduced in #2374

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD miracle Mysterious events are happening here labels Feb 21, 2025
@RobinTail
Using pnpm -F for workspaces.
b488446
@RobinTail
Installing linting dependencies to the root.
ef5381b
@RobinTail
Enabling Corepack for CI.
d12037e
@RobinTail
Using pnpm cache by setup node action.
7e8e458
@RobinTail
mv corepack before node setup.
5786a8d
@RobinTail
temp: no cache.
d11f606
@RobinTail
Changing pm in CI.
26825bb
@RobinTail
Fixed dependencies for running tests.
7ad3e72
@RobinTail
Address corepack integrity issue: rm sha.
117b1fa
@RobinTail
Revert "Address corepack integrity issue: rm sha."
0342d83 
This reverts commit 117b1fa.
@RobinTail
Temp: Disabling corepack integrity keys.
da5104b
@RobinTail
Fixing non-portable types for DTS build.
259ec80
@RobinTail
Fix postbuild ATTW.
5da7161
@RobinTail
Replacing yarn in several commands.
1a0b2d6
@RobinTail
Add cross workspace reference to example (fixes build).
7bf9b29
@RobinTail
Add undici dev dep to example test.
968e099
@RobinTail
Add cross ws ref to intergration tests.
d0a8db5
@RobinTail
Fix env for the test of issue 952.
3e5b7af
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Feb 21, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling ec717c0 on try-pnpm-again
into aa433fb on master.

@RobinTail RobinTail marked this pull request as ready for review February 24, 2025 10:01
RobinTail
RobinTail commented Feb 24, 2025
View reviewed changes
@RobinTail
Copy link
Owner Author

Let's try to make a beta and to publish it

@RobinTail
Copy link
Owner Author

RobinTail commented Feb 24, 2025 •
edited
Loading

For some reason postversion runs before every version command I tried.
UPD: the reason is that npm version expects .git folder to be on the same level as package.json (weird): npm/cli#2010

@RobinTail
Copy link
Owner Author

I wonder why every package manager is so buggy.

@RobinTail
Copy link
Owner Author

✅ no regression in the release

This was referenced Feb 25, 2025
Closed
Closed
@RobinTail RobinTail marked this pull request as draft February 26, 2025 12:11
@RobinTail
Copy link
Owner Author

RobinTail commented Feb 26, 2025 •
edited
Loading

I'm not fully satisfied with the current state of pnpm and therefore wanna try bun as well

@RobinTail RobinTail mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation miracle Mysterious events are happening here
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail