Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package support for ament_cmake_mypy #267

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

seanpai96
Copy link
Contributor

Adding support for ament_cmake_mypy. Build completed without errors.
Because I currently don't have other OSes, so I'm only adding support for arm64 Macs.

@traversaro
Copy link
Member

Adding support for ament_cmake_mypy. Build completed without errors.
Because I currently don't have other OSes, so I'm only adding support for arm64 Macs.

Thanks! As it is a Python package, can you try to add it for all platforms? We can remove them if they fail to build.

@seanpai96
Copy link
Contributor Author

Tested on all platforms, built completely without errors!

@seanpai96 seanpai96 changed the title feat: add package support for ament_cmake_mypy (mac_arm64) feat: add package support for ament_cmake_mypy Feb 12, 2025
@traversaro
Copy link
Member

Tested on all platforms, built completely without errors!

Great, thanks!

@Tobias-Fischer Tobias-Fischer merged commit 715d9ca into RoboStack:main Feb 12, 2025
5 checks passed
@seanpai96
Copy link
Contributor Author

Hmm.. when installing the package, the package reported that it needs python_abi=3.11 which doesn't match the humble's 3.10. What should I do to fix this problem?

截圖 2025-02-12 下午5 47 46

@Tobias-Fischer
Copy link
Contributor

humble is on 3.11 as well - please create a new environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants